chore: upgrade rrweb to alpha.17 #25736
Conversation
| timeOffset, | ||
| mutation | ||
| }) { | ||
| + if (!this.isSupportedMediaElement(target)) return; |
There was a problem hiding this comment.
Suggested fix in rrweb-io/rrweb#1462 that allows us to remove the previous target?.pause() patches
| + onError: (e) => { | ||
| + // maintain the existing behaviour of throwing if no handler is provided | ||
| + throw e; | ||
| + }, |
There was a problem hiding this comment.
Originally introduced in #19868. Do you want to keep this around @pauldambra? If we removed it we'd be down to a single one line patch (which has an open PR from Justin) on the playback side
There was a problem hiding this comment.
interesting... doesn't look like we're setting a handler
so this feels orphaned to me
if you concur there is no handler than i humbly submit it can be terminated with medium prejudice
There was a problem hiding this comment.
Handler is here:
There was a problem hiding this comment.
ah, intereseting, caught 110 errors in the last 30 days https://posthog.sentry.io/issues/?project=1899813&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D%20feature%3A%22replayer%20error%20swallowed%22&referrer=issue-list&statsPeriod=30d&utc=true
(Which we haven't looked at 🙈 )
| new file mode 100644 | ||
| index 0000000000000000000000000000000000000000..0a6c5930c017852afd3d7f0170f6eca821619dd3 | ||
| --- /dev/null | ||
| +++ b/es/rrweb/packages/rrweb-snapshot/es/css.js |
There was a problem hiding this comment.
Now that rrweb-io/rrweb#1458 we don't need any of the custom CSS stuff in a separate patch (basically everything below this line until the end of the file)
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Closing in favour of PostHog/posthog-js#1489 |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Whoops, wrong PR |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
adding bundle analyzer to rrweb and building gives this for the console recorder 🤯
|
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This reverts commit a7e35f5.
Problem
We need to upgrade rrweb to remove our reliance on a bunch of patches that have since been merged
Changes
target?.pause()patches